Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed object/members listing failing when name contains variant chars #2215

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

sebjulliand
Copy link
Collaborator

Changes

Listing objects and/or members with names containing variant characters using a profile with CCSID different from 37 would result in members being displayed with American variant characters and physical source files not being displayed or being displayed as regular PF.

Example, with CCSID 297 variants characters:

Before this PR, when listing members
image

After this PR
image

Before this PR, when listing source physical files:
With Object type = *ALL
image
With Object type = *SRCPF
image

After this PR
image
image

Turns out the system tables contains the names in CCSID 37 and the OBJECT_STATISTICS table function does translates the names to the connection's CCSID before returning the results.

How to test this PR

  1. Connect with a profile with CCSID other than 37
  2. Create a member with one or more variant characters
  3. It must be displayed correctly and can be opened.

Checklist

  • have tested my change

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
@sebjulliand sebjulliand added the bug A confirmed issue when something isn't working as intended label Aug 5, 2024
@sebjulliand sebjulliand added this to the 2.12.0 milestone Aug 5, 2024
@sebjulliand sebjulliand self-assigned this Aug 5, 2024
Copy link
Contributor

@worksofliam worksofliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with manual testing and running the existing test cases.

I am not pressed for this PR, but is it at-all possible to have a test case that runs when the user CCSID is not 37 to automate this testing>?

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
@sebjulliand
Copy link
Collaborator Author

Approved with manual testing and running the existing test cases.
Thanks @worksofliam !

I am not pressed for this PR, but is it at-all possible to have a test case that runs when the user CCSID is not 37 to automate this testing>?
There you go, I added a test that will run if CCSID is not 37. It can run on PUB400 as well, the library test part is simply skipped in this case.
Good thing you had me add this test since I eventually found a bug that remained (filtering on source files name would not work if the filter had variant characters).

Give it a last try and let me know what you think!

@worksofliam worksofliam merged commit 2ad2163 into master Aug 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A confirmed issue when something isn't working as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants