Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action to open location after download of members/streamfiles #2224

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

sebjulliand
Copy link
Collaborator

Changes

This PR adds an Open button on the notification shown after a successful streamfile/member download.
image

Cliking on Open will reveal the location of the downloaded file(s) in the OS native file explorer.

How to test this PR

  1. Download a member/streamfile
  2. Click on open
  3. Download a source physical file/multiple streamfiles
  4. Click open

Checklist

  • have tested my change

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
@sebjulliand sebjulliand added the enhancement New feature or request label Aug 23, 2024
@sebjulliand sebjulliand self-assigned this Aug 23, 2024
@worksofliam
Copy link
Contributor

Where did you get this branch name from? :o

fix/memberVariantCharacters

Testing now!

Copy link
Contributor

@worksofliam worksofliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good - and working on my mac! Nice PR!

image

@sebjulliand
Copy link
Collaborator Author

Where did you get this branch name from? :o

fix/memberVariantCharacters

Testing now!

Ugh, I didn't pay attention and used a branch that was used for another PR and deleted in the meantime 😥

@sebjulliand
Copy link
Collaborator Author

Code looks good - and working on my mac! Nice PR!
image

Thanks mate! Merging!

@sebjulliand sebjulliand merged commit 815ed05 into master Aug 23, 2024
1 check passed
@sebjulliand sebjulliand deleted the fix/memberVariantCharacters branch August 23, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants