Fix missing lint config filter option

Signed-off-by: worksofliam <mrliamallan@live.co.uk>
codefori · Apr 29, 2024 · 7ed8096 · 7ed8096
1 parent 85e58b4
commit 7ed8096
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/extension/client/src/linter.ts b/extension/client/src/linter.ts
@@ -55,7 +55,13 @@ export function initialise(context: ExtensionContext) {
 
 				if (filter && filter.description) {
 					// Bad way to get the library for the filter ..
-					const library = (filter.description.split(`/`)[0]).toLocaleUpperCase();
+					const library: string = (filter.description.split(`/`)[0]).toLocaleUpperCase();
+
+					if (library.includes(`*`)) {
+						window.showErrorMessage(`Cannot show lint config for a library filter.`);
+						return;
+					}
+
 					configPath = `${library}/VSCODE/RPGLINT.JSON`;
 
 					exists = (await connection.runCommand({

diff --git a/package.json b/package.json
@@ -68,7 +68,7 @@
 			"view/item/context": [
 				{
 					"command": "vscode-rpgle.openLintConfig",
-					"when": "view == objectBrowser && viewItem == filter",
+					"when": "view == objectBrowser && viewItem =~ /^filter.*$/",
 					"group": "1_LibActions@2"
 				}
 			]