Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update production enviroment name #291

Merged

Conversation

ayuki-joto
Copy link
Collaborator

🎩 What? Why?

decidim v0-23-5のデプロイ時に環境を切り替えのたのでそれに追従するための変更
また、nginxのtimeoutに追従してpumaのtimeoutを伸ばす処理も含めています。

📌 Related Issues

📋 Subtasks

  • Add CHANGELOG upgrade notes, if required
  • If there's a new public field, add it to GraphQL API
  • Add documentation regarding the feature
  • Add/modify seeds
  • Add tests
  • Another subtask

Copy link
Contributor

@komtaki komtaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MR自体は、LGTMです。

ただredisのノードが4で一つ増えているのが気になりました。特に理由がないなら、現状の3ノードのままでよい気がしました。 🤔

それと安定したならCloud Frontを通るよう修正をお願いします。 *.diycities.jpのレコードをCloud Frontのエイリアスに戻して、production-alb-origin.diycities.jpのAレコードを新環境のElastic beanstalkのALBに切り替えればokです。

config/puma.rb Outdated
@@ -37,3 +37,5 @@

# Allow puma to be restarted by `rails restart` command.
plugin :tmp_restart

worker_timeout 180
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これですが、単純なレスポンスのタイムアウトではないかもです
https://www.rubydoc.info/gems/puma/Puma%2FDSL:worker_timeout

This is not a request timeout, it is to protect against a hung or dead process. Setting this value will not protect against slow requests.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

なるほど、ではこちらは一旦触らない方向で問題あれば直すにします!

Copy link
Collaborator

@takahashim takahashim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

他は特に異論ないです 🙆

@ayuki-joto ayuki-joto merged commit 5c5eee5 into codeforjapan:develop Oct 18, 2021
@ayuki-joto ayuki-joto deleted the update-production-enviroment-name branch February 21, 2022 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants