-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update production enviroment name #291
Update production enviroment name #291
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MR自体は、LGTMです。
ただredisのノードが4で一つ増えているのが気になりました。特に理由がないなら、現状の3ノードのままでよい気がしました。 🤔
それと安定したならCloud Frontを通るよう修正をお願いします。 *.diycities.jpのレコードをCloud Frontのエイリアスに戻して、production-alb-origin.diycities.jpのAレコードを新環境のElastic beanstalkのALBに切り替えればokです。
config/puma.rb
Outdated
@@ -37,3 +37,5 @@ | |||
|
|||
# Allow puma to be restarted by `rails restart` command. | |||
plugin :tmp_restart | |||
|
|||
worker_timeout 180 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
これですが、単純なレスポンスのタイムアウトではないかもです
https://www.rubydoc.info/gems/puma/Puma%2FDSL:worker_timeout
This is not a request timeout, it is to protect against a hung or dead process. Setting this value will not protect against slow requests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
なるほど、ではこちらは一旦触らない方向で問題あれば直すにします!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
他は特に異論ないです 🙆
🎩 What? Why?
decidim v0-23-5のデプロイ時に環境を切り替えのたのでそれに追従するための変更
また、nginxのtimeoutに追従してpumaのtimeoutを伸ばす処理も含めています。
📌 Related Issues
📋 Subtasks
CHANGELOG
upgrade notes, if required