Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove baseurl #969

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from
Open

Remove baseurl #969

wants to merge 1 commit into from

Conversation

petk
Copy link
Contributor

@petk petk commented Jan 27, 2023

The site.baseurl configuration value should only be used when the resulting site lives at a subpath of the domain [1].

This also fixes the syntax highlighting on pages (basics, functional programming etc.).

1: https://ben.balter.com/jekyll-style-guide/config/#baseurl

The site.baseurl configuration value should only be used when the
resulting site lives at a subpath of the domain [1].

This also fixes the syntax highlighting on pages (basics, functional
programming etc.).

[1]: https://ben.balter.com/jekyll-style-guide/config/#baseurl
@jrfnl
Copy link
Contributor

jrfnl commented Jan 27, 2023

The point of having the setup like this, is that it allows to test the site locally. If these things are removed, in my experience, things go wonky when running the Jekyll site locally. (Note: this may have been fixed in Jekyll/the GH Pages plugin since the original setup, but I don't know for sure)

@petk
Copy link
Contributor Author

petk commented Jan 27, 2023

The baseurl doesn't work neither locally. It is overwritten to an empty value on GitHub pages.

User should create their own baseurl value for these forked repos to be displayed on username.github.io/php-the-right-way which isn't even wanted actually due to search engines complications.

For the local installation, Jekyll page is displayed on the http://localhost:4000 so there isn't any baseurl there anyway.

@jrfnl
Copy link
Contributor

jrfnl commented Jan 27, 2023

As I said, things may have been fixed in Jekyll/GHPages since the original setup ;-) Good to know that it still works locally without the baseurl with the current versions.

@Xymph
Copy link
Collaborator

Xymph commented Jan 29, 2023

Punting this to @codeguy too.

@Xymph Xymph requested a review from codeguy January 29, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants