* Replace Vector with ArrayList

* Deprecate JNamedMap in favor of LinkedHashMap * Replace StringBuffer with StringBuilder * Update surefire
codehaus-plexus · Dec 31, 2018 · c486d6b · c486d6b
1 parent af7a3a1
commit c486d6b
Show file tree

Hide file tree

Showing 31 changed files with 251 additions and 369 deletions.
diff --git a/modello-core/src/main/java/org/codehaus/modello/plugin/AbstractModelloGenerator.java b/modello-core/src/main/java/org/codehaus/modello/plugin/AbstractModelloGenerator.java
@@ -180,7 +180,7 @@ protected String capitalise( String str )
             return str;
         }
 
-        return new StringBuffer( str.length() )
+        return new StringBuilder( str.length() )
             .append( Character.toTitleCase( str.charAt( 0 ) ) )
             .append( str.substring( 1 ) )
             .toString();
@@ -220,7 +220,7 @@ public static String uncapitalise( String str )
             return str;
         }
 
-        return new StringBuffer( str.length() )
+        return new StringBuilder( str.length() )
             .append( Character.toLowerCase( str.charAt( 0 ) ) )
             .append( str.substring( 1 ) )
             .toString();

diff --git a/modello-maven-plugin/src/it/maven-model/src/main/mdo/maven.mdo b/modello-maven-plugin/src/it/maven-model/src/main/mdo/maven.mdo
@@ -494,7 +494,7 @@
           <code><![CDATA[
             public String getId()
             {
-                StringBuffer id = new StringBuffer();
+                StringBuilder id = new StringBuilder();
 
                 id.append( getGroupId() );
                 id.append( ":" );
@@ -1748,7 +1748,7 @@
           <code><![CDATA[
             public String getId()
             {
-                StringBuffer id = new StringBuffer();
+                StringBuilder id = new StringBuilder();
 
                 id.append( getGroupId() );
                 id.append( ":" );

diff --git a/modello-plugins/modello-plugin-converters/src/test/resources/models/maven.mdo b/modello-plugins/modello-plugin-converters/src/test/resources/models/maven.mdo
@@ -493,7 +493,7 @@
           <code>
             public String getId()
             {
-            StringBuffer id = new StringBuffer();
+            StringBuilder id = new StringBuilder();
 
             id.append( getGroupId() );
             id.append( ":" );

diff --git a/modello-plugins/modello-plugin-dom4j/src/test/resources/maven.mdo b/modello-plugins/modello-plugin-dom4j/src/test/resources/maven.mdo
@@ -491,7 +491,7 @@
           <code>
             public String getId()
             {
-            StringBuffer id = new StringBuffer();
+            StringBuilder id = new StringBuilder();
 
             id.append( getGroupId() );
             id.append( ":" );

diff --git a/modello-plugins/modello-plugin-jackson/src/test/resources/maven.mdo b/modello-plugins/modello-plugin-jackson/src/test/resources/maven.mdo
@@ -515,7 +515,7 @@
           <code>
             public String getId()
             {
-            StringBuffer id = new StringBuffer();
+            StringBuilder id = new StringBuilder();
 
             id.append( getGroupId() );
             id.append( ":" );

diff --git a/...ello-plugin-java/src/main/java/org/codehaus/modello/plugin/java/JavaModelloGenerator.java b/...ello-plugin-java/src/main/java/org/codehaus/modello/plugin/java/JavaModelloGenerator.java
@@ -428,7 +428,7 @@ private JMethod generateToString( ModelClass modelClass, boolean onlyIdentifierF
         }
         else
         {
-            sc.add( "StringBuffer buf = new StringBuffer( 128 );" );
+            sc.add( "StringBuilder buf = new StringBuilder( 128 );" );
         }
 
         sc.add( "" );
@@ -1246,7 +1246,7 @@ private JMethod createGetter( JField field, ModelField modelField )
 
         JMethod getter = new JMethod( prefix + propertyName, returnType, null );
 
-        StringBuffer comment = new StringBuffer( "Get " );
+        StringBuilder comment = new StringBuilder( "Get " );
         if ( StringUtils.isEmpty( modelField.getDescription() ) )
         {
             comment.append( "the " );
@@ -1286,7 +1286,7 @@ private JMethod createSetter( JField field, ModelField modelField, boolean isBui
             setter = new JMethod( "set" + propertyName );
         }
 
-        StringBuffer comment = new StringBuffer( "Set " );
+        StringBuilder comment = new StringBuilder( "Set " );
         if ( StringUtils.isEmpty( modelField.getDescription() ) )
         {
             comment.append( "the " );