Use a caching writer to avoid overwriting identical files #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-o
reviewed
Jan 31, 2022
| @@ -107,7 +107,7 @@ private void generateJsonSchema( Properties parameters ) | |||
| .enable( JsonWriteFeature.QUOTE_FIELD_NAMES.mappedFeature() ) | |||
| .enable( JsonWriteFeature.QUOTE_FIELD_NAMES.mappedFeature() ) | |||
| .disable( JsonWriteFeature.WRITE_NUMBERS_AS_STRINGS.mappedFeature() ) | |||
| .createGenerator( schemaFile, JsonEncoding.UTF8 ); | |||
| .createGenerator( newWriter( schemaFile.toPath() ) ); | |||
There was a problem hiding this comment.
This is wrong. JSON is by definition UTF-8 and nothing else. I think this breaks it.
This was referenced Feb 21, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rfscholte
This can improve build time quite substantially. For example the maven re-build (no clean, no tests) goes from 32.8s down to 28.8s on my laptop. So that's an easy 12% benefit.
I'm going to submit a PR for the maven-resource-plugin too.