Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix detection of invalid spaces in prolog #20

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Fix detection of invalid spaces in prolog #20

merged 1 commit into from
Jun 23, 2023

Conversation

gnodet
Copy link
Member

@gnodet gnodet commented Jun 23, 2023

No description provided.

@gnodet gnodet requested a review from cstamas June 23, 2023 11:57
@gnodet gnodet force-pushed the invalid-space-in-prolog branch from 44a8f2c to b3c7fab Compare June 23, 2023 12:01
@gnodet gnodet force-pushed the invalid-space-in-prolog branch from b3c7fab to e91d954 Compare June 23, 2023 12:04
cstamas
cstamas approved these changes Jun 23, 2023
View reviewed changes
Copy link
Member

@cstamas cstamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this will now make XML with newline as first line always (and consistently) fail on all plaf

@gnodet
Copy link
Member Author

gnodet commented Jun 23, 2023

So this will now make XML with newline as first line always (and consistently) fail on all plaf

Yes. When the xmldecl <?xml ...?> is present, it has to be at the very beginning of the file and no whitespace is allowed before. The problem is that a single whitespace could be silently discarded and it was thus failing on windows when using \r\n as the line separator because of the length of 2.

@gnodet gnodet added this to the 4.0.1 milestone Jun 23, 2023
@gnodet gnodet merged commit d227a49 into codehaus-plexus:master Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cstamas cstamas cstamas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@gnodet @cstamas