refactor: compare to 0 on preg_match_all()

codeigniter4 · Dec 27, 2024 · aa6f5ee · aa6f5ee
1 parent 5caee6a
commit aa6f5ee
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/system/Session/Handlers/MemcachedHandler.php b/system/Session/Handlers/MemcachedHandler.php
@@ -93,12 +93,12 @@ public function open($path, $name): bool
         }
 
         if (
-            in_array(preg_match_all(
+            preg_match_all(
                 '#,?([^,:]+)\:(\d{1,5})(?:\:(\d+))?#',
                 $this->savePath,
                 $matches,
                 PREG_SET_ORDER
-            ), [0, false], true)
+            ) === 0
         ) {
             $this->memcached = null;
             $this->logger->error('Session: Invalid Memcached save path format: ' . $this->savePath);

diff --git a/system/View/Parser.php b/system/View/Parser.php
@@ -691,7 +691,7 @@ protected function parsePlugins(string $template)
              *   $matches[1] = all parameters string in opening tag
              *   $matches[2] = content between the tags to send to the plugin.
              */
-            if (in_array(preg_match_all($pattern, $template, $matches, PREG_SET_ORDER), [0, false], true)) {
+            if (preg_match_all($pattern, $template, $matches, PREG_SET_ORDER) === 0) {
                 continue;
             }