refactor: use compare equals 1 for preg_match() return on array_filter

codeigniter4 · Dec 28, 2024 · f29210c · f29210c
1 parent a2ec505
commit f29210c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/system/Helpers/form_helper.php b/system/Helpers/form_helper.php
@@ -739,10 +739,10 @@ function validation_show_error(string $field, string $template = 'single'): stri
         $config = config(Validation::class);
         $view   = service('renderer');
 
-        $errors = array_filter(validation_errors(), static fn ($key): false|int => preg_match(
+        $errors = array_filter(validation_errors(), static fn ($key): bool => preg_match(
             '/^' . str_replace(['\.\*', '\*\.'], ['\..+', '.+\.'], preg_quote($field, '/')) . '$/',
             $key
-        ), ARRAY_FILTER_USE_KEY);
+        ) === 1, ARRAY_FILTER_USE_KEY);
 
         if ($errors === []) {
             return '';

diff --git a/system/Validation/Validation.php b/system/Validation/Validation.php
@@ -176,7 +176,7 @@ public function run(?array $data = null, ?string $group = null, $dbGroup = null)
 
                 $values = array_filter(
                     $flattenedArray,
-                    static fn ($key): false|int => preg_match(self::getRegex($field), $key),
+                    static fn ($key): bool => preg_match(self::getRegex($field), $key) === 1,
                     ARRAY_FILTER_USE_KEY
                 );
 
@@ -867,7 +867,7 @@ public function getError(?string $field = null): string
 
         $errors = array_filter(
             $this->getErrors(),
-            static fn ($key): false|int => preg_match(self::getRegex($field), $key),
+            static fn ($key): bool => preg_match(self::getRegex($field), $key) === 1,
             ARRAY_FILTER_USE_KEY
         );