Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to FakerPHP #3827

Merged
merged 1 commit into from
Oct 28, 2020
Merged

Switch to FakerPHP #3827

merged 1 commit into from
Oct 28, 2020

Conversation

MGatner
Copy link
Member

@MGatner MGatner commented Oct 27, 2020

Description
fzaninotto has archived his project and asked others to continue it on fork. The solution seems to be FakerPHP/Faker, which this PR implements.

See: fzaninotto/Faker#2063

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • n/a User guide updated
  • Conforms to style guide

@lonnieezell lonnieezell merged commit 75a0525 into codeigniter4:develop Oct 28, 2020
@paulbalandan
Copy link
Member

I think the composer.json in the admin/ folder should be updated too.

@paulbalandan paulbalandan mentioned this pull request Oct 28, 2020
Merged
1 task
@MGatner MGatner deleted the fakerphp branch November 8, 2020 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MGatner @paulbalandan @lonnieezell