Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop PHP 8.0 support #8042

Merged
merged 6 commits into from
Oct 20, 2023
Merged

Drop PHP 8.0 support #8042

merged 6 commits into from
Oct 20, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Oct 13, 2023

Description
See #7320
Ref #7924

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the 4.5 label Oct 13, 2023
kenjis added 2 commits October 13, 2023 17:38
@kenjis
refactor: add return types to __toString()
8d5ec54 
See https://psalm.dev/docs/running_psalm/issues/MethodSignatureMustProvideReturnType/
@kenjis
chore: drop PHP 8.3 for php-cs-fixer
188c967 
Run vendor/bin/php-cs-fixer fix --verbose --ansi --dry-run --config=.php-cs-fixer.no-header.php --using-cache=no --diff
PHP needs to be a minimum version of PHP 7.4.0 and maximum version of PHP 8.2.*.
Current PHP version: 8.3.0-dev.
To ignore this requirement please set `PHP_CS_FIXER_IGNORE_ENV`.
If you use PHP version higher than supported, you may experience code modified in a wrong way.
Please report such cases at https://github.com/PHP-CS-Fixer/PHP-CS-Fixer .
Error: Process completed with exit code 1.
@kenjis kenjis mentioned this pull request Oct 13, 2023
Closed
michalsn
michalsn approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@michalsn michalsn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even now PHP 8.0 has a lower usage than PHP 7.4... and we already dropped PHP 7.4... For that reason, I would be in favor of doing this. Security support for PHP 8.0 ends in a month.

https://packagist.org/packages/codeigniter4/framework/php-stats#4.4
https://www.php.net/supported-versions.php

CodeIgniter 4.5 will most likely land in 2024 anyway.

MGatner
MGatner approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. What a time to be alive.

@kenjis kenjis merged commit 26bc784 into codeigniter4:4.5 Oct 20, 2023
45 checks passed
@kenjis kenjis deleted the drop-php-8.0-CI45 branch October 20, 2023 23:00
@kenjis
Copy link
Member Author

kenjis commented Oct 20, 2023

🎉

1 similar comment
@paulbalandan
Copy link
Member

🎉

@kenjis kenjis mentioned this pull request Oct 21, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
4.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kenjis @paulbalandan @michalsn @MGatner