Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve error message in SiteURI::normalizeBaseURL() #8143

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Nov 4, 2023

Description
We don't know what is invalid in the current error message.

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis changed the title refactor: improve error message in SiteURI::normalizeBaseURL() fix: improve error message in SiteURI::normalizeBaseURL() Nov 4, 2023
@kenjis kenjis force-pushed the fix-SiteURI-normalizeBaseURL branch from 3550bb0 to f966357 Compare November 4, 2023 04:39
@kenjis kenjis merged commit c3613ca into codeigniter4:develop Nov 6, 2023
60 checks passed
@kenjis kenjis deleted the fix-SiteURI-normalizeBaseURL branch November 6, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants