Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add CSP clearDirective() to clear existing directive #8220

Merged
merged 6 commits into from
Nov 19, 2023
Merged

feat: add CSP clearDirective() to clear existing directive #8220

merged 6 commits into from
Nov 19, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Nov 15, 2023 •
edited
Loading

Description
Closes #8213

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added enhancement PRs that improve existing functionalities 4.5 docs needed Pull requests needing documentation write-ups and/or revisions. labels Nov 15, 2023
@kenjis kenjis mentioned this pull request Nov 15, 2023
Closed
@kenjis kenjis force-pushed the feat-csp-clearDirective branch from d390403 to 3ac6433 Compare November 17, 2023 07:25
@kenjis kenjis removed the docs needed Pull requests needing documentation write-ups and/or revisions. label Nov 17, 2023
@kenjis
Copy link
Member Author

kenjis commented Nov 17, 2023

Added to support report-uri: 37ab92e and docs.

@kenjis kenjis requested review from michalsn and crustamet November 17, 2023 07:28
@kenjis kenjis merged commit 3846204 into codeigniter4:4.5 Nov 19, 2023
46 checks passed
@kenjis kenjis deleted the feat-csp-clearDirective branch November 19, 2023 21:00
crustamet
crustamet reviewed Nov 20, 2023
View reviewed changes
Copy link
Contributor

@crustamet crustamet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a lot of stuff done here :)

@michalsn michalsn linked an issue Dec 10, 2023 that may be closed by this pull request
No way to remove an already added CSP header #8213
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crustamet crustamet crustamet approved these changes

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
4.5 enhancement PRs that improve existing functionalities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No way to remove an already added CSP header
3 participants
@kenjis @michalsn @crustamet