Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update phpstan-baseline #8857

Merged
merged 2 commits into from
May 6, 2024
Merged

chore: update phpstan-baseline #8857

merged 2 commits into from
May 6, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented May 6, 2024 •
edited
Loading

Description
Follow-up #8821

  • add tests/ for PHPStan paths
  • update PHPStan baseline

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the 4.6 label May 6, 2024
@kenjis kenjis marked this pull request as draft May 6, 2024 09:16
@kenjis kenjis force-pushed the update-phpstan-baseline branch from b5f82e9 to cfa7878 Compare May 6, 2024 10:08
@kenjis kenjis changed the base branch from 4.6 to develop May 6, 2024 10:08
@kenjis kenjis removed the 4.6 label May 6, 2024
@kenjis kenjis changed the title [4.6] chore: update phpstan-baseline chore: update phpstan-baseline May 6, 2024
@kenjis kenjis added the github_actions Pull requests that update Github_actions code label May 6, 2024
@kenjis kenjis marked this pull request as ready for review May 6, 2024 10:09
@kenjis kenjis merged commit 84e06d0 into codeigniter4:develop May 6, 2024
8 checks passed
@kenjis kenjis deleted the update-phpstan-baseline branch May 6, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
github_actions Pull requests that update Github_actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @michalsn