Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: fix phpstan only boolean allowed #9302

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

neznaika0
Copy link
Contributor

Description
Fixed all errors like

Only booleans are allowed in ...

I tried to apply the typing adequately during the checks. For a more accurate fix, you need to update the code instead of phpdoc.
It is possible to additionally check for null, false, <empty-string> somewhere
Fixed 92 errors out of 3925

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

system/CLI/CLI.php Outdated Show resolved Hide resolved
system/CLI/CLI.php Outdated Show resolved Hide resolved
@github-actions github-actions bot added the stale Pull requests with conflicts label Dec 11, 2024
Copy link

👋 Hi, @neznaika0!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

@neznaika0 neznaika0 force-pushed the fix-phpstan-only-boolean-allowed branch from f6bb767 to 37a924d Compare December 11, 2024 17:54
@neznaika0 neznaika0 force-pushed the fix-phpstan-only-boolean-allowed branch 2 times, most recently from 0bf76f5 to f3a85de Compare December 11, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Pull requests with conflicts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants