-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace deprecated Faker property access #620
Merged
kenjis
merged 1 commit into
codeigniter4:develop
from
kenjis:update-faker-accessing-property
Feb 3, 2023
Merged
refactor: replace deprecated Faker property access #620
kenjis
merged 1 commit into
codeigniter4:develop
from
kenjis:update-faker-accessing-property
Feb 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbalandan
approved these changes
Feb 2, 2023
datamweb
approved these changes
Feb 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New to me :
lonnieezell
approved these changes
Feb 2, 2023
ErrorException: Since fakerphp/faker 1.14: Accessing property "userName" is deprecated, use "userName()" instead.
kenjis
force-pushed
the
update-faker-accessing-property
branch
from
February 3, 2023 04:39
d1584a3
to
54be9f0
Compare
Rebased. $ CODEIGNITER_SCREAM_DEPRECATIONS=true composer test
> phpunit
PHPUnit 9.5.28 by Sebastian Bergmann and contributors.
Runtime: PHP 8.1.13
Configuration: /Users/kenji/work/codeigniter/official/codeigniter-shield/phpunit.xml
Random Seed: 1675399200
............................................................... 63 / 290 ( 21%)
............................................................... 126 / 290 ( 43%)
............................................................... 189 / 290 ( 65%)
............................................................... 252 / 290 ( 86%)
...................................... 290 / 290 (100%)
Nexus\PHPUnit\Extension\Tachycardia identified these 8 slow tests:
+---------------------------------------------------------------------------------+---------------+-------------+
| Test Case | Time Consumed | Time Limit |
+---------------------------------------------------------------------------------+---------------+-------------+
| Tests\\Authentication\\ForcePasswordResetTest::testForceGlobalPasswordReset | 00:00:04.36 | 00:00:00.50 |
| Tests\\Unit\\DictionaryValidatorTest::testCheckTrueOnNotFound | 00:00:01.78 | 00:00:00.50 |
| Tests\\Controllers\\RegisterTest::testRegisteredButNotActivatedAndRegisterAgain | 00:00:01.28 | 00:00:00.50 |
| Tests\\Controllers\\RegisterTest::testRegisterRedirectsToActionIfDefined | 00:00:01.28 | 00:00:00.50 |
| Tests\\Controllers\\RegisterTest::testRegisteredAndSessionExpiredAndLogin | 00:00:01.25 | 00:00:00.50 |
| Tests\\Controllers\\RegisterTest::testRegisteredButNotActivatedAndLogin | 00:00:01.24 | 00:00:00.50 |
| Tests\\Controllers\\RegisterTest::testRegisterActionSuccess | 00:00:01.20 | 00:00:00.50 |
| Tests\\Unit\\UserIdentityModelTest::testForceMultiplePasswordReset | 00:00:00.93 | 00:00:00.50 |
+---------------------------------------------------------------------------------+---------------+-------------+
Time: 00:31.441, Memory: 44.00 MB
OK (290 tests, 647 assertions)
|
@paulbalandan I just noticed why the |
@kenjis so that you can just copy paste them when using the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E.g. ErrorException: Since fakerphp/faker 1.14: Accessing property "userName" is deprecated, use "userName()" instead.
Try: