Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lang: translate pt-BR strings #673

Merged
merged 3 commits into from
Mar 15, 2023
Merged

Conversation

onovaes
Copy link
Contributor

@onovaes onovaes commented Mar 14, 2023

Supersedes #672

Added portuguese (pt-BR) translations

@datamweb datamweb added the lang Languages file label Mar 14, 2023
@datamweb datamweb changed the title Translate pt-br strings lang: translate pt-BR strings Mar 14, 2023
Copy link
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@onovaes Thanks, congratulations, well done!

@@ -90,7 +90,7 @@
'emailActivateMailBody' => 'Use o código abaixo para ativar sua conta e começar a usar o site.',
'invalidActivateToken' => 'O código estava incorreto.',
'needActivate' => 'Você deve concluir seu registro confirmando o código enviado para seu endereço de e-mail.',
'activationBlocked' => '(to be translated) You must activate your account before logging in.',
'activationBlocked' => 'Você deve ativar sua conta antes de fazer login.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sugestão: Login é uma palavra que estrangeira em PT-BR, não seria interessante substituir fazer login por iniciar sessão ?

Copy link
Contributor Author

@onovaes onovaes Mar 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O meu português é de DEV, rs.. Aacho legal sua sugestão e fiz um novo commit. Valeu @robsonpiere

Copy link
Contributor

@robsonpiere robsonpiere Mar 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Que legal que gostou da sugestão, mas vi aqui que tem mais locais onde o texto é login, abri um outro comentário e seria legal ver sua opinão como BR também hehe

@datamweb
Copy link
Collaborator

@caosdp-rs believed that the use of the word Login is common, for this reason did not translate:

'login' => 'Login',

@onovaes
Copy link
Contributor Author

onovaes commented Mar 14, 2023

@caosdp-rs believed that the use of the word Login is common, for this reason did not translate:

'login' => 'Login',

Brazilian Portuguese is a little different.

"Start Session" makes more sense in that activationBlocked string

@robsonpiere
Copy link
Contributor

robsonpiere commented Mar 14, 2023

Hi @onovaes , @datamweb !

I saw here in the file that the word login is used in other parts of the translation, and I agree that it would be nice to keep a standard. What do you think? Keep the word login at all or default to "Iniciar Sessão" ?

@onovaes
Copy link
Contributor Author

onovaes commented Mar 14, 2023 via email

@onovaes
Copy link
Contributor Author

onovaes commented Mar 15, 2023

@datamweb Let's use "fazer o login" .

I believe to be correct, because the is quite used here. I sent a new commit.

https://drive.google.com/file/d/1tD8OK89z9LeTlPho3YMNFSQ26Y1XBuAp/view?usp=sharing

@datamweb
Copy link
Collaborator

@robsonpiere Thanks for contributing to this discussion.

@onovaes My goal was just a reminder.

In this regard, I do not know Brazilian, so the final decision must be made by you.
Choose a phrase that is common and well known. Any translation that the people of your country are comfortable with.

@onovaes
Copy link
Contributor Author

onovaes commented Mar 15, 2023 via email

@datamweb datamweb merged commit b19bd0e into codeigniter4:develop Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang Languages file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants