Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typo in getMaxLengthRule() method name #728

Merged
merged 3 commits into from
May 2, 2023
Merged

fix: typo in getMaxLengthRule() method name #728

merged 3 commits into from
May 2, 2023

Conversation

bgeneto
Copy link
Contributor

@bgeneto bgeneto commented May 2, 2023

The getMaxLenghtRule() method name has a typo and should be renamed to getMaxLengthRule() in 3 source files.

@datamweb datamweb changed the title Fixed typo in getMaxLengthRule() method name fix: typo in getMaxLengthRule() method name May 2, 2023
datamweb
datamweb approved these changes May 2, 2023
View reviewed changes
Copy link
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch.

kenjis
kenjis approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kenjis kenjis added the refactor Pull requests that refactor code label May 2, 2023
@kenjis kenjis merged commit 0ceb817 into codeigniter4:develop May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datamweb datamweb datamweb approved these changes

@kenjis kenjis kenjis approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bgeneto @kenjis @datamweb