-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add support for all request types when building a user from request. #747
fix: add support for all request types when building a user from request. #747
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
See what Kenjis says.
Can you tell me why you need this? A use case? |
Yes. A use case is trying to register users using JWT authentication. |
@sammyskills Thanks. I think |
We cannot remove the method call, so suppress the PHPStan error at that point.
https://github.com/codeigniter4/shield/actions/runs/5031981449/jobs/9025363859?pr=747 |
Fixed. |
@sammyskills Thank you! |
Previously, the
ValidationRules::buildUserFromRequest()
only checks forPOST
ed requests.With this PR, it can now check for any type of request including json requests.
Fixes #612