Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cannot register when you remove email from $validFields #829

Merged
merged 2 commits into from
Sep 18, 2023
Merged

fix: cannot register when you remove email from $validFields #829

merged 2 commits into from
Sep 18, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Sep 13, 2023

Description
Fixes #654

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Something isn't working label Sep 13, 2023
@kenjis kenjis mentioned this pull request Sep 13, 2023
Closed
@kenjis
test: add test for registation with no email login
d629cd4
@kenjis
fix: cannot register when you remove email from $validFields
b18e7ea 
CodeIgniter\Shield\Exceptions\LogicException : "$user->id" is null. You should not use the incomplete User object.
@kenjis kenjis force-pushed the fix-ValidationRules-prepareValidFields branch from e9e0a45 to b18e7ea Compare September 13, 2023 08:02
@datamweb datamweb changed the title fix: cannot register when you remove email from $validFields fix: cannot register when you remove email from $validFields Sep 17, 2023
datamweb
datamweb approved these changes Sep 17, 2023
View reviewed changes
Copy link
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kenjis thank you!
LGTM!

@kenjis kenjis merged commit 4dcee8f into codeigniter4:develop Sep 18, 2023
29 checks passed
@kenjis kenjis deleted the fix-ValidationRules-prepareValidFields branch September 18, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datamweb datamweb datamweb approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Registration doesn't work: "$user->id is null. You should not use the incomplete User object."
2 participants
@kenjis @datamweb