-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: refactor Auth #908
perf: refactor Auth #908
Conversation
@kenjis, we can use command OR /**
* --------------------------------------------------------------------
* Load of Auth collector in Debugbar
* --------------------------------------------------------------------
* By default, Auth in Debugbar is loaded in mode `development`.
* If you want Auth in Debugbar not to be loaded even in `development` mode,
* set the `false`.
*/
public bool $showAuthInDebugbar = true; Config/Registrar.php: public static function Toolbar(): array
{
return (config('Auth')->showAuthInDebugbar) ?
[
'collectors' => [
Auth::class,
],
] : [];
} |
Config\Auth extends Shield\Config\Auth. So both are always loaded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I fell in love with this PR 😊.
Description
See #905 (reply in thread)
service('auth')->routes($routes)
createsAuthentication
andUserModel
instances.Before:
After:
Checklist: