New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace `url_is()` #915

Merged

kenjis merged 1 commit into codeigniter4:develop from kenjis:fix-remove-url_is

Oct 18, 2023

Member

kenjis commented Oct 18, 2023

Description
url_is() checks the URI path. If the path is changed by devs, it will not work.

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide


          fix: replace url_is()

a8287bb

url_is() checks the URI path. If the path is changed, it will not work.

kenjis added the bug label

datamweb approved these changes

View reviewed changes

lonnieezell approved these changes

View reviewed changes

kenjis merged commit 46a6da7 into codeigniter4:develop

32 checks passed

kenjis deleted the fix-remove-url_is branch

October 18, 2023 21:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug