Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete Vietnamese language. #470

Merged
merged 4 commits into from
Oct 15, 2024
Merged

Complete Vietnamese language. #470

merged 4 commits into from
Oct 15, 2024

Conversation

tuyenht
Copy link
Contributor

@tuyenht tuyenht commented Oct 9, 2024

Translate the complete Vietnamese language for CodeIgniter4.

@tuyenht
Complete Vietnamese language.
8ee0aef 
Translate the complete Vietnamese language for CodeIgniter4.
paulbalandan
paulbalandan requested changes Oct 9, 2024
View reviewed changes
Copy link
Member

@paulbalandan paulbalandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tuyenht , thank you for the changes!

In order for this PR to be merged, we need to fix the following:

  1. Add missing Migration.batch entry
  2. Fix code style. Please run vendor/bin/php-cs-fixer fix -v

@tuyenht

This comment was marked as resolved.

Sign in to view
tuyenht and others added 2 commits October 15, 2024 10:59
@tuyenht @paulbalandan
Complete all translations for Vietnamese language.
f804380 
Co-Authored-By: John Paul E. Balandan, CPA <51850998+paulbalandan@users.noreply.github.com>
@tuyenht @paulbalandan
Update VietnameseTranslationTest.php
109c01d 
Co-Authored-By: John Paul E. Balandan, CPA <51850998+paulbalandan@users.noreply.github.com>
@tuyenht tuyenht requested a review from paulbalandan October 15, 2024 04:12
@tuyenht
Copy link
Contributor Author

tuyenht commented Oct 15, 2024

I was changed.

@paulbalandan
Copy link
Member

In VietnameseTranslationTest:

  1. add a comma after 'Migrations.version'
  2. Add a new line at the end of file

@tuyenht @paulbalandan
Update VietnameseTranslationTest.php
1913c1b 
Co-Authored-By: John Paul E. Balandan, CPA <51850998+paulbalandan@users.noreply.github.com>
@tuyenht
Copy link
Contributor Author

tuyenht commented Oct 15, 2024

Hi,
I have made the requested changes in the VietnameseTranslationTest file by adding a comma after 'Migrations.version' and adding a new line at the end of the file. Please let me know if there’s anything else you need.

Thanks.

In VietnameseTranslationTest:

  1. add a comma after 'Migrations.version'
  2. Add a new line at the end of file

@paulbalandan paulbalandan merged commit 21fce8e into codeigniter4:develop Oct 15, 2024
11 checks passed
@paulbalandan
Copy link
Member

Thank you, @tuyenht

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tuyenht @paulbalandan