Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Use "Distribution" certificate for iOS App AdHoc profiles #198

Merged

Conversation

priitlatt
Copy link
Contributor

@priitlatt priitlatt commented Feb 2, 2022

Continuation to the improvements first introduced in #185. There the default certificate type for iOS App distribution provisioning profiles was changed from iOS Distribution to Distribution so that single certificate could be used for provisioning profiles targeting different platforms.
Similar change can be also made for iOS App AdHoc profiles. Up until now iOS AdHoc profiles were mapped to iOS Distribution certificates, but those too can use the platform-independent Distribution certificates. So, with the changes here
provisioning profiles of type IOS_APP_ADHOC are assigned certificates with type DISTRIBUTION (as opposed to IOS_DISTIBUTION which was used before), when downloaded (or created) using action app-store-connect fetch-signing-files. This allows reusing one signing certificate for signing apps that target different platforms, and reduces need to create excess certificates in Apple Developer Portal.

Updated default provisioning profile type to certificate type is now as follows:

  • IOS_APP_ADHOC provisioning profiles use DISTRIBUTION certificates by default (previously IOS_DISTRIBUTION).

The change is backwards compatible in the sense that existing matching IOS_DISTRIBUTION certificates are still used for iOS App AdHoc provisioning profiles in case they are found and no DISTRIBUTION certificates are present.

Updated actions:

  • app-store-connect fetch-signing-files.

@priitlatt priitlatt marked this pull request as ready for review February 3, 2022 08:47
…ature/distribution-certificates-for-ios-adhoc-profiles
@priitlatt priitlatt merged commit 8878c32 into master Feb 3, 2022
@priitlatt priitlatt deleted the feature/distribution-certificates-for-ios-adhoc-profiles branch February 3, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants