Development: Make iter_backwards
work on file-like objects
#255
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In utilities package
codemagic.utilities.backwards_file_reader
there is a functioniter_backwards
that can be used to iterate over lines in file from bottom to top.Currently it only works with files that are saved to disk and the function takes file path (as a string or
pathlib.Path
object) as an argument.But in reality the files are not always saved to the disk, and can be stored in-memory. In such cases the path is not available and as a result
iter_backwards
function cannot be used.Changes in this PR add support to iterate lines on file-like objects too.
Examples of updated usage: