Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Do not require release notes for Firebase releases #323

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

priitlatt
Copy link
Contributor

Not all Firebase App Distribution releases have release notes attached to them. This causes related firebase-app-distribution actions to fail with the following exception:

Traceback (most recent call last):
  File "/Users/builder/.pyenv/versions/3.8.13/lib/python3.8/site-packages/codemagic/cli/cli_app.py", line 212, in invoke_cli
    CliApp._running_app._invoke_action(args)
  File "/Users/builder/.pyenv/versions/3.8.13/lib/python3.8/site-packages/codemagic/cli/cli_app.py", line 168, in _invoke_action
    return cli_action(**action_args)
  File "/Users/builder/.pyenv/versions/3.8.13/lib/python3.8/site-packages/codemagic/cli/cli_app.py", line 463, in wrapper
    return func(self, *args, **kwargs)
  File "/Users/builder/.pyenv/versions/3.8.13/lib/python3.8/site-packages/codemagic/tools/firebase_app_distribution/actions/get_latest_build_version_action.py", line 23, in get_latest_build_version
    releases = self.client.releases.list(app_identifier, limit=1)
  File "/Users/builder/.pyenv/versions/3.8.13/lib/python3.8/site-packages/codemagic/google/resource_managers/mixins/listing_manager_mixin.py", line 68, in list
    resources.extend(self.resource_type(**item) for item in response[self.resource_type.get_label()])
  File "/Users/builder/.pyenv/versions/3.8.13/lib/python3.8/site-packages/codemagic/google/resource_managers/mixins/listing_manager_mixin.py", line 68, in <genexpr>
    resources.extend(self.resource_type(**item) for item in response[self.resource_type.get_label()])
TypeError: __init__() missing 1 required positional argument: 'releaseNotes'

Make releaseNotes field on Release object optional.

@priitlatt priitlatt added the bug Something isn't working label Jun 21, 2023
@priitlatt priitlatt merged commit a7df5d8 into master Jun 21, 2023
@priitlatt priitlatt deleted the bugfix/optional-firebase-release-notes branch June 21, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant