Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to configure timeout for finding build from App Store Connect #355

Merged
merged 9 commits into from
Oct 3, 2023

Conversation

priitlatt
Copy link
Contributor

@priitlatt priitlatt commented Sep 25, 2023

Resolves #350.

Once a binary is uploaded to Apple using app-store-connect publish it can take quite some time for the corresponding build to appear in App Store Connect UI and API responses. Build reference is needed to automatically submit the freshly uploaded version to TestFlight or App Store right after publishing.

For now there is a fixed 10 minute timeout period to find the build after upload completes. Occasionally this does not suffice and consequently publishing as a whole fails.

Changes in this pull request introduce new command line option --max-find-build-wait which can be used to configure the duration of the waiting period before.

Screenshot 2023-09-25 at 15 36 15

Updated actions

  • app-store-connect publish

@priitlatt priitlatt added the enhancement New feature or request label Sep 25, 2023
@priitlatt priitlatt marked this pull request as ready for review September 25, 2023 13:17
@priitlatt
Copy link
Contributor Author

@helinanever please check the copy.

priitlatt and others added 2 commits October 3, 2023 11:24
Co-authored-by: helinanever <36853001+helinanever@users.noreply.github.com>
Copy link
Contributor

@helinanever helinanever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priitlatt priitlatt merged commit d7d5db1 into master Oct 3, 2023
5 checks passed
@priitlatt priitlatt deleted the feature/customizable-timeout-to-find-build branch October 3, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make retries for finding build customizable
3 participants