Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore node_modules by default #113

Closed
eventualbuddha opened this issue Mar 28, 2018 · 3 comments
Closed

Ignore node_modules by default #113

eventualbuddha opened this issue Mar 28, 2018 · 3 comments

Comments

@eventualbuddha
Copy link
Collaborator

Maybe should be customizable, maybe not.
@rwjblue
Copy link

rwjblue commented Jun 24, 2018

I think perhaps changing this area to use globby instead of glob would allow us to ignore all .gitignored files by default.

https://github.com/square/babel-codemod/blob/00ae5984e1b2ca2fac923011ce16157a29b12b39/src/Options.ts#L135-L139

What do you think?

eventualbuddha added a commit that referenced this issue Jul 1, 2018
@eventualbuddha
fix(cli): ignore gitignored files
6ede0d0 
Closes #113
@eventualbuddha eventualbuddha mentioned this issue Jul 1, 2018
Merged
eventualbuddha added a commit that referenced this issue Jul 1, 2018
@eventualbuddha
fix(cli): ignore gitignored files
87fa129 
Closes #113
@eventualbuddha
Copy link
Collaborator Author

That's a good suggestion. Thanks, @rwjblue!

eventualbuddha added a commit that referenced this issue Jul 1, 2018
@eventualbuddha
fix(cli): ignore gitignored files
9697c85 
Closes #113
@babel-codemod-bot
Copy link

🎉 This issue has been resolved in version 2.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eventualbuddha @rwjblue @babel-codemod-bot