Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

genearte_exception_message_for_git #734

Open
wants to merge 1 commit into
base: 3.x
Choose a base branch
from

Conversation

i053322
Copy link
Contributor

@i053322 i053322 commented Aug 9, 2016

What does this PR do?

In action like clone , fetch , pull , push I added messages for case of SSL or if the message start with file name to long security issue,

What issues does this PR fix or reference?

The message handle in two new cases:

  1. SSL in case of SSLHandshakeException we raise message SAP Web IDE is not configured to trust the security certificate provided by the Git server.
  2. in case that the message start with "file name too long" - there is security issue, error message should not include complete local file path on the target system

Previous Behavior

Remove this section if not relevant
The message that raisewas from Throwable message

New Behavior

This content may also be included in the release notes.

Tests written?

Yes/No
There are tests for all the git actions

Docs requirements?

Include the content for all the docs changes required.

  1. API changes
  2. User docs changes

Please review Che's Contributing Guide for best practices.

Change-Id: I399e92bd075f1282be90fc3cdd1aadd470261ae8
Signed-off-by: i053322 yossi.balan@sap.com

Change-Id: I399e92bd075f1282be90fc3cdd1aadd470261ae8
Signed-off-by: i053322 <yossi.balan@sap.com>
@i053322
Copy link
Contributor Author

i053322 commented Aug 9, 2016

@vinokurig - create the PR from che 4.x

@vinokurig
Copy link
Contributor

OK for me

@skabashnyuk
Copy link
Contributor

ok. @tareqhs up to you to merge with PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants