Skip to content

Commit

Permalink
Add platform to vscode-reh-web task
Browse files Browse the repository at this point in the history
Our strategy has been to build once and then recompile native modules
for individual platforms.  It looks like VS Code builds from scratch for
each platform.

But we can target any platform, grab the pre-packaged folder, then
continue with own packaging.

In the future we may want to rework to match upstream.
  • Loading branch information
code-asher committed Nov 4, 2021
1 parent 062ce32 commit 2481711
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
2 changes: 1 addition & 1 deletion ci/build/build-release.sh
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ EOF
bundle_vscode() {
mkdir -p "$VSCODE_OUT_PATH"
rsync "$VSCODE_SRC_PATH/yarn.lock" "$VSCODE_OUT_PATH"
rsync "$VSCODE_SRC_PATH/out-vscode-server${MINIFY:+-min}/" "$VSCODE_OUT_PATH/out"
rsync "$VSCODE_SRC_PATH/out-vscode-reh-web${MINIFY:+-min}/" "$VSCODE_OUT_PATH/out"

rsync "$VSCODE_SRC_PATH/.build/extensions/" "$VSCODE_OUT_PATH/extensions"
if [ "$KEEP_MODULES" = 0 ]; then
Expand Down
5 changes: 2 additions & 3 deletions ci/build/build-vscode.sh
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,8 @@ main() {

cd vendor/modules/code-oss-dev

# extensions-ci compiles extensions and includes their media.
# compile-web compiles web extensions. TODO: Unsure if used.
yarn gulp extensions-ci compile-web "vscode-reh-web${MINIFY:+-min}"
# Any platform works since we have our own packaging step (for now).
yarn gulp "vscode-reh-web-linux-x64${MINIFY:+-min}"
}

main "$@"

0 comments on commit 2481711

Please sign in to comment.