Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push code-server image to GHCR #5187

Merged
merged 3 commits into from
May 10, 2022
Merged

Push code-server image to GHCR #5187

merged 3 commits into from
May 10, 2022

Conversation

onedr0p
Copy link
Contributor

@onedr0p onedr0p commented May 10, 2022

Fixes #3335

@onedr0p onedr0p marked this pull request as ready for review May 10, 2022 20:28
@onedr0p onedr0p requested a review from a team May 10, 2022 20:28
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!! Thanks for taking care of this!

@code-asher code-asher enabled auto-merge (squash) May 10, 2022 20:29
@code-asher code-asher disabled auto-merge May 10, 2022 20:29
@code-asher code-asher enabled auto-merge (squash) May 10, 2022 20:30
@code-asher code-asher disabled auto-merge May 10, 2022 20:31
@onedr0p
Copy link
Contributor Author

onedr0p commented May 10, 2022

I think there might need to be some action on the maintainer side for the coder org, you may need to enable packages, see:

image

@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #5187 (c66728a) into main (53b5d41) will not change coverage.
The diff coverage is n/a.

❗ Current head c66728a differs from pull request most recent head 7dda7f9. Consider uploading reports for the commit 7dda7f9 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5187   +/-   ##
=======================================
  Coverage   71.81%   71.81%           
=======================================
  Files          30       30           
  Lines        1689     1689           
  Branches      374      374           
=======================================
  Hits         1213     1213           
  Misses        408      408           
  Partials       68       68           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53b5d41...7dda7f9. Read the comment docs.

@code-asher code-asher merged commit 7a8d487 into coder:main May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide alternate image registry to dockerhub
2 participants