Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deal with devcontainer.json "liberties" #38

Closed
geiseri opened this issue Jul 20, 2023 · 2 comments · Fixed by #41
Closed

Deal with devcontainer.json "liberties" #38

geiseri opened this issue Jul 20, 2023 · 2 comments · Fixed by #41
Assignees
@kylecarbs

Comments

@geiseri
Copy link

geiseri commented Jul 20, 2023

It looks like envbuilder's json parser is not okay with trailing , in arrays, or json comments. Not sure what can be done with this, as I assume its using a 3rd party parser that might not support vscode's liberties taken with json.
@aaronlehmann
Copy link
Collaborator

Yeah, devcontainer.json files seem to routinely include nonstandard JSON like comments and trailing commas. In one of my projects, I'm using github.com/trapcodeio/go-strip-json-comments to strip both comments and trailing commas.

@kylecarbs
Copy link
Member

Ahh, I'll fix this!

@kylecarbs kylecarbs self-assigned this Jul 25, 2023
kylecarbs added a commit that referenced this issue Jul 25, 2023
@kylecarbs
fix: allow json with comments and trailing commas
01d438e 
Fixes #38.
@kylecarbs kylecarbs mentioned this issue Jul 25, 2023
Merged
kylecarbs added a commit that referenced this issue Jul 25, 2023
@kylecarbs
fix: allow json with comments and trailing commas
5a48fe0 
Fixes #38.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: allow json with comments and trailing commas coder/envbuilder
3 participants
@geiseri @kylecarbs @aaronlehmann