Remove unused function 'getName' #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code serves no function and is therefore being removed
|
Nice, thanks a lot :) |
coderaiser
pushed a commit
that referenced
this pull request
Feb 15, 2021
This code serves no function and is therefore being removed
|
Landed in v7.0.1 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I wanted to help improve code coverage (#55), and the first thing I stumbled upon seems to be code that isn't used anymore. I believe this code can be removed.
getNamechecks to see if theoptimizefunction has been passed an object instead of a string, in which case it tries to turn the object into a string. But it doesn't seem like it is possible to pass it an object. If I try to pass an object tominify, it will throw an error, and the documentation you wrote foroptimizespecifically calls for a string - no mention of an object.In older versions of minify, it seems like some of these functions could be accessed much more directly, so I would guess that something was passing weird objects directly to
optimize, andgetNamewas built to accept those edge cases. That doesn't seem to be necessary anymore :)I am also working on adding test coverage for the remaining parts of your code. Thank you for this awesome package!