Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete code coverage #64

Merged
merged 1 commit into from
Feb 18, 2021
Merged

Complete code coverage #64

merged 1 commit into from
Feb 18, 2021

Conversation

atjn
Copy link
Contributor

@atjn atjn commented Feb 17, 2021

This PR adds three new tests which bumps the code coverage to 100%. I hope you like them!

Closes #55

@coveralls
Copy link

coveralls commented Feb 17, 2021

Coverage Status

Coverage remained the same at 100.0% when pulling 0dc4ee1 on atjn:test-coverage into c45992b on coderaiser:master.

@atjn
Copy link
Contributor Author

atjn commented Feb 18, 2021

I'm not sure how coveralls concluded that coverage already was 100%. Here's what my terminal says:

Before:

-----------|---------|----------|---------|---------|-------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
-----------|---------|----------|---------|---------|-------------------
All files  |     100 |    84.62 |     100 |     100 |                   
 css.js    |     100 |       80 |     100 |     100 | 27                
 html.js   |     100 |      100 |     100 |     100 |                   
 img.js    |     100 |    66.67 |     100 |     100 | 29                
 js.js     |     100 |      100 |     100 |     100 |                   
 minify.js |     100 |       80 |     100 |     100 | 32,71             
-----------|---------|----------|---------|---------|-------------------

After:

-----------|---------|----------|---------|---------|-------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
-----------|---------|----------|---------|---------|-------------------
All files  |     100 |      100 |     100 |     100 |                   
 css.js    |     100 |      100 |     100 |     100 |                   
 html.js   |     100 |      100 |     100 |     100 |                   
 img.js    |     100 |      100 |     100 |     100 |                   
 js.js     |     100 |      100 |     100 |     100 |                   
 minify.js |     100 |      100 |     100 |     100 |                   
-----------|---------|----------|---------|---------|-------------------

@coderaiser coderaiser merged commit 23da207 into coderaiser:master Feb 18, 2021
@coderaiser
Copy link
Owner

Nice, thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve coverage
3 participants