Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mentor profile page #205

Merged
merged 1 commit into from
Oct 10, 2023
Merged

fix: mentor profile page #205

merged 1 commit into from
Oct 10, 2023

Conversation

ruilopesm
Copy link
Member

No description provided.

@reviewpad
Copy link

reviewpad bot commented Oct 10, 2023

AI-Generated Summary: This pull request introduces a fix to the mentor profile page functionality in the 'MentorView' module. It modifies the way skills are processed and displayed. Before, the program used to render each individual skill via the 'SkillView' module. However, with the updates, skills are now directly converted to JSON data using the 'SkillJSON' module. Additionally, the pull request refines the code by removing the unnecessary double alias statement and splitting it into two separate alias statements for better readability. This change involves 3 insertions and 2 deletions in the 'lib/bokken_web/views/mentor_view.ex' file.

@ruilopesm ruilopesm merged commit 00ba0ca into main Oct 10, 2023
3 checks passed
@ruilopesm ruilopesm deleted the rl/fix-mentor-profile branch October 10, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants