-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update condition before calling delete and decrementing counter #1074
Open
MatousJobanek
wants to merge
9
commits into
codeready-toolchain:master
Choose a base branch
from
MatousJobanek:update-condition-before-deletion
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: update condition before calling delete and decrementing counter #1074
MatousJobanek
wants to merge
9
commits into
codeready-toolchain:master
from
MatousJobanek:update-condition-before-deletion
+47
−8
Commits on Aug 14, 2024
-
fix: update condition before calling delete and decrementing counter
Devtools committedAug 14, 2024 Configuration menu - View commit details
-
Copy full SHA for 96631c5 - Browse repository at this point
Copy the full SHA 96631c5View commit details -
Devtools committed
Aug 14, 2024 Configuration menu - View commit details
-
Copy full SHA for fe26208 - Browse repository at this point
Copy the full SHA fe26208View commit details
Commits on Aug 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7a052f4 - Browse repository at this point
Copy the full SHA 7a052f4View commit details
Commits on Aug 19, 2024
-
Update controllers/space/space_controller_test.go
Co-authored-by: Rajiv Senthilnathan <rajivnathan@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for eb036d1 - Browse repository at this point
Copy the full SHA eb036d1View commit details -
Update controllers/space/space_controller_test.go
Co-authored-by: Rajiv Senthilnathan <rajivnathan@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6c37b14 - Browse repository at this point
Copy the full SHA 6c37b14View commit details -
Configuration menu - View commit details
-
Copy full SHA for e9211eb - Browse repository at this point
Copy the full SHA e9211ebView commit details
Commits on Aug 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fabd2af - Browse repository at this point
Copy the full SHA fabd2afView commit details
Commits on Sep 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 771be16 - Browse repository at this point
Copy the full SHA 771be16View commit details
Commits on Sep 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 16cd3f2 - Browse repository at this point
Copy the full SHA 16cd3f2View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.