-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drag and drop animations #223
base: main
Are you sure you want to change the base?
Conversation
…proper height, made basic draggable scalable
…nto update-simple-drag-and-drop-foodgroupV2
FoodGroups (wheel)
- Added hover scale transitions to draggable characters.
…at' above others.
…alues for better-sized Draggables.
…oat when they are no longer being hovered on.
… when dragged, refactored hover zoom to work with wiggle.
… further animations, and changed image size to fit.
…component devolved childrens styling and had to be forced back into relative positioning
…codersforcauses/foodbank into update-simple-drag-and-drop-foodgroupV2
Co-authored-by: Peter <peter-tanner@users.noreply.github.com>
…hub.com/codersforcauses/foodbank into update-simple-drag-and-drop-foodgroupV2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are accessibility issues in these changes.
|
||
return ( | ||
<> | ||
<Image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image is missing a text alternative (alt
attribute). This is a problem for people using screen readers.
…page on pages of width 1024px or wider.
Change Summary
[Briefly summarise the changes that you made. Just high-level stuff]
Change Form
Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.
Other Information
[Is there anything in particular in the review that I should be aware of?]