Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign-up page enhancement #134

Closed
2 tasks
Tracked by #154
SeiKasahara opened this issue Jul 14, 2024 · 3 comments
Closed
2 tasks
Tracked by #154

Sign-up page enhancement #134

SeiKasahara opened this issue Jul 14, 2024 · 3 comments
Assignees
Labels
difficulty:medium enhancement New feature or request frontend Task must have a front end issue priority:medium

Comments

@SeiKasahara
Copy link
Collaborator

Basic Information

  • Username and email address should be checked if it's unique when users click the next button, since the database has unique constraint.

Considering async function example be like

export const checkUnique = async (
  input: string,
  type: 'email' | 'username',
): Promise<string> => {
  try {
    const response = await api.get(`/check-unique?${type}=${input}`);
    // axios automatically parses the response as JSON if the content type is application/json
    const data = response.data;

    if (data[`${type}_taken`]) {
      return data[`${type}_error_message`];
    }
    return '';
  } catch (error) {
    //... error handling block
  }
};

The backend should return a error_message to frontend.

  • The password page should be added, including following functions:
  1. Password should be checked as same as confirm password. Example function is like:
function passwordValidation(password: string, repeatPassword: string) {
  if (repeatPassword != password) {
    return false;
  }
  return true;
}
  1. [Optional Enhancement] Considering security issues, the strength of the user's entered password should be checked.
@SeiKasahara SeiKasahara added enhancement New feature or request frontend Task must have a front end issue difficulty:medium priority:medium labels Jul 14, 2024
@SeiKasahara SeiKasahara self-assigned this Jul 14, 2024
Copy link

Branch issue-134-Sign-up_page_enhancement created!

@SeiKasahara
Copy link
Collaborator Author

Preparing to combine #65 works on this branch. And also make reconstrcuction on it.

@ErikaKK
Copy link
Contributor

ErikaKK commented Aug 1, 2024

This was done in #65

@ErikaKK ErikaKK closed this as completed Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty:medium enhancement New feature or request frontend Task must have a front end issue priority:medium
Projects
None yet
Development

No branches or pull requests

2 participants