Issue 150 store token from server in local storage #155

ErikaKK · 2024-07-21T15:15:40Z

Change Summary

Store token to local storage when sign in in sign-in.tsx page.
Changed fake API in poster page index.tsx, got task list from db API using axios interceptor in /lib/api.ts
Moved and removed some poster page files bc they were not very organized before
Add API call in poster page new-task.tsx, got error response

Changed form.tsx and input.tsx bc Show/warn about required fields not being filled in in forms #110 made some changes that affect the sign-in.tsx

Change Form

Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.

The pull request title has an issue number
The change works by "Smoke testing" or quick testing
The change has tests
The change has documentation

Other Information

Bc the design of db login table only has username field instead of email or mobile. I changed the login field label in sign-in.tsx

Related issue

Resolve Store token from server in local storage (RAM or cookie idk) - Sign in and Sign up #150

vercel · 2024-07-21T15:15:43Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
penni	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 23, 2024 5:26am

SodaVolcano

Have some console.log that should be removed probably, but looks pretty good!

SodaVolcano · 2024-07-21T15:35:13Z

client/src/pages/sign-in.tsx

@@ -61,7 +72,7 @@ export default function SignIn({ account }: { account: string }) {
            <SingleLineInput
              type="text"
              name="account"
-              label="Email or mobile"
+              label="Username"


Replace with Email or mobile, "username" is not usually associated with emails or mobile but actual user names like SodaVolcano, can be confusing

client/src/pages/sign-in.tsx

client/src/lib/api.ts

client/src/pages/poster/index.tsx

…issue-150-Store_token_from_server_in_local_storage_RAM_or_cookie_idk_-_Sign_in_and_Sign_up

SeiKasahara · 2024-07-22T05:28:47Z

client/src/pages/sign-in.tsx

+const LOGIN_URL = LocalBaseURL.concat("/app/login/");
+
+const handleLogin = async (username: string, password: string) => {
+  const response = await axios.post(LOGIN_URL, {


Should we use the api in the lib?

I wrote this so I use it. It works well

ErikaKK · 2024-07-22T06:18:55Z

To satisfy current fields in db, have to use username to login. Needs to change later

SodaVolcano

Looks pretty good, remove the validation if you want (can always go back to a previous commit if we need the regex pattern again)

SodaVolcano · 2024-07-22T06:20:00Z

client/src/pages/sign-in.tsx

    const isEmail = /^[a-zA-Z\._'\d-]+@[a-zA-Z]+(\.[a-zA-Z]+)+$/.test(
      formData.account,
    );
    const isPhone = /^[0-9]{10}$/.test(formData.account);

-    if (!isEmail && !isPhone) {
-      setErrorMessage("Invalid email or phone number. Please try again.");
-      return;
-    }
+    // if (!isEmail && !isPhone) {
+    //   setErrorMessage("Invalid email or phone number. Please try again.");
+    //   return;
+    // }


Feel free to remove validation if you think it should be done only on the server side. I guess we have to send the details to the server anyway so it doesn't matter if we also validate it there as well.

Ok thanks now they only use username to login. I'll change later

Now the login API uses username in the payload. I'll change later

CodeWithTheDoctor · 2024-07-22T08:40:54Z

I wasn't sure how to test this so can't review it.

What I tried: Opened localhost:3000, enetered my email and name, clicked "Finish", saw a confirmation on the console page.

But token doesn't appear in the localstorage?

Let me know if there's something else I should be looking for!

ErikaKK · 2024-07-22T09:00:35Z

I wasn't sure how to test this so can't review it.

What I tried: Opened localhost:3000, enetered my email and name, clicked "Finish", saw a confirmation on the console page.

But token doesn't appear in the localstorage?

Let me know if there's something else I should be looking for!

Someone else is working on this signup page #134
My team made the signin page. You can access http://localhost:3000/signin-test and click register to signup a user with

email: "user1@example.com",
        password: "user123abc@#",
        username: "user1",

Then go to http://localhost:3000/sign-in. You have to use the username in the Email or mobile field to login bc that's how the api is designed. and then you can see the token in local storage

ErikaKK · 2024-07-22T09:39:29Z

@CodeWithTheDoctor

yunho7687

please fix the conflict : )

…issue-150-Store_token_from_server_in_local_storage_RAM_or_cookie_idk_-_Sign_in_and_Sign_up The changes in #110 made signin page unable to submit so I discarded these changes

…M_or_cookie_idk_-_Sign_in_and_Sign_up' and 'main' of https://github.com/codersforcauses/penni into issue-150-Store_token_from_server_in_local_storage_RAM_or_cookie_idk_-_Sign_in_and_Sign_up

ErikaKK added 3 commits July 21, 2024 06:41

Store token when sign in

dfc661f

Change poster page index.tsx fake api.

7755b6b

Comment console.log test code

6530b9a

ErikaKK requested review from SodaVolcano and yunho7687 July 21, 2024 15:15

Delete useless code

70f5542

vercel bot deployed to Preview July 21, 2024 15:32 View deployment

SodaVolcano requested changes Jul 21, 2024

View reviewed changes

ErikaKK added 2 commits July 22, 2024 03:04

Remove some debug code. Add some api call

059051d

Merge branch 'main' of https://github.com/codersforcauses/penni into …

c5740ee

…issue-150-Store_token_from_server_in_local_storage_RAM_or_cookie_idk_-_Sign_in_and_Sign_up

SeiKasahara reviewed Jul 22, 2024

View reviewed changes

Add api call in new-task.tsx

9d9925b

ErikaKK requested a review from SodaVolcano July 22, 2024 06:14

vercel bot deployed to Preview July 22, 2024 06:15 View deployment

SodaVolcano approved these changes Jul 22, 2024

View reviewed changes

yunho7687 requested a review from CodeWithTheDoctor July 22, 2024 07:54

yunho7687 reviewed Jul 23, 2024

View reviewed changes

Merge branch 'main' of https://github.com/codersforcauses/penni into …

9ef4ca3

…issue-150-Store_token_from_server_in_local_storage_RAM_or_cookie_idk_-_Sign_in_and_Sign_up The changes in #110 made signin page unable to submit so I discarded these changes

vercel bot deployed to Preview July 23, 2024 03:47 View deployment

Test the api got invalid pk response

c390b81

vercel bot deployed to Preview July 23, 2024 03:53 View deployment

yunho7687 approved these changes Jul 23, 2024

View reviewed changes

Merge branches 'issue-150-Store_token_from_server_in_local_storage_RA…

73173b8

…M_or_cookie_idk_-_Sign_in_and_Sign_up' and 'main' of https://github.com/codersforcauses/penni into issue-150-Store_token_from_server_in_local_storage_RAM_or_cookie_idk_-_Sign_in_and_Sign_up

vercel bot deployed to Preview July 23, 2024 05:26 View deployment

ErikaKK merged commit 0ebf7ff into main Jul 23, 2024
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue 150 store token from server in local storage #155

Issue 150 store token from server in local storage #155

ErikaKK commented Jul 21, 2024 •

edited

Loading

vercel bot commented Jul 21, 2024 •

edited

Loading

SodaVolcano left a comment

SodaVolcano Jul 21, 2024

SeiKasahara Jul 22, 2024

ErikaKK Jul 22, 2024

ErikaKK commented Jul 22, 2024

SodaVolcano left a comment

SodaVolcano Jul 22, 2024

ErikaKK Jul 22, 2024

ErikaKK Jul 22, 2024

CodeWithTheDoctor commented Jul 22, 2024

ErikaKK commented Jul 22, 2024

ErikaKK commented Jul 22, 2024

yunho7687 left a comment

Issue 150 store token from server in local storage #155

Issue 150 store token from server in local storage #155

Conversation

ErikaKK commented Jul 21, 2024 • edited Loading

Change Summary

Change Form

Other Information

Related issue

vercel bot commented Jul 21, 2024 • edited Loading

SodaVolcano left a comment

Choose a reason for hiding this comment

SodaVolcano Jul 21, 2024

Choose a reason for hiding this comment

SeiKasahara Jul 22, 2024

Choose a reason for hiding this comment

ErikaKK Jul 22, 2024

Choose a reason for hiding this comment

ErikaKK commented Jul 22, 2024

SodaVolcano left a comment

Choose a reason for hiding this comment

SodaVolcano Jul 22, 2024

Choose a reason for hiding this comment

ErikaKK Jul 22, 2024

Choose a reason for hiding this comment

ErikaKK Jul 22, 2024

Choose a reason for hiding this comment

CodeWithTheDoctor commented Jul 22, 2024

ErikaKK commented Jul 22, 2024

ErikaKK commented Jul 22, 2024

yunho7687 left a comment

Choose a reason for hiding this comment

ErikaKK commented Jul 21, 2024 •

edited

Loading

vercel bot commented Jul 21, 2024 •

edited

Loading