Fix build issues #2001
Merged
Fix build issues #2001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CompuIves
reviewed
May 31, 2019
| @@ -315,6 +315,7 @@ module.exports = { | |||
| resolve: { | |||
| mainFields: ['browser', 'module', 'jsnext:main', 'main'], | |||
| modules: [ | |||
| path.resolve(__dirname, '../node_modules'), | |||
There was a problem hiding this comment.
Yes, otherwise webpack resolves the below node_modules to the hoisted root node_modules, and not app/node_modules, for some (not yet clear to me) reason.
|
Should be ready to merge. |
…pe removed, and: - remove unneeded code from webpack config - fix PR build URL to use https - fix the a11y linting bug - extract jest messages to common
|
@lbogdan Shouldn't we make an issue/PR upstream too to fix the bug? 🤔 |
|
Since it's fixed upstream, I've updated the |
batiskafff
pushed a commit
to batiskafff/codesandbox-client
that referenced
this pull request
Jun 19, 2019
…pe removed, and: (codesandbox#2001) - remove unneeded code from webpack config - fix PR build URL to use https - fix the a11y linting bug - extract jest messages to common
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the current build issues caused by an apparent bug in
babel-eslint@10.0.1byupgrading tousing ourbabel-eslint@11.0.0-beta.0babel-eslinkfork, from which we removed thepatch-eslint-scopereference:There's also a few small fixes, see the commit message.