Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checkout action and problem matcher to README #32

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vadi2
Copy link

@vadi2 vadi2 commented Aug 21, 2021

Just as a subtle hint for people to find the other ones easier.

Thanks for the nice action!

Copy link
Collaborator

@peternewman peternewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment

README.md Outdated
@@ -6,7 +6,9 @@ Any warnings or errors will be annotated in the Pull Request.
## Usage

```
uses: codespell-project/actions-codespell@master
- uses: actions/checkout@v2
- uses: codespell-project/codespell-problem-matcher@v1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't need the matcher @vadi2 , it's built into this action (but provided separately for people who want to do things a bit differently).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had no idea! https://github.com/codespell-project/codespell-problem-matcher lead me to believe that it had to be added.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please feel free to open a PR if we can improve the wording of that repo so it's clear it's not required with our main action?

Copy link
Collaborator

@peternewman peternewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having the usage example be valid action YAML certainly makes sense, would you mind making all the examples match though please throughout the doc?

@peternewman peternewman added the enhancement New feature or request label Sep 22, 2021
@peternewman peternewman linked an issue Sep 22, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doesn't work?
2 participants