Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub Actions #49

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

DimitriPapadopoulos
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@peternewman peternewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

Is there not a Dependabot or something we can get to do this automagically in future?

@DimitriPapadopoulos
Copy link
Collaborator Author

Yes, we can add a dependabot. However, I'd like to understand why it doesn't work in some cases, see for example bids-standard/bids-specification#1303.

@per1234
Copy link
Contributor

per1234 commented Sep 27, 2022

However, I'd like to understand why it doesn't work in some cases

I have experienced the same thing. It seems to be significantly delayed in some cases. For example, we enabled the action updates 2022-05-02 in a repository:

arduino/serial-monitor@4f1f74b

And only finally received the PR for the actions/checkout@v2 -> actions/checkout@v3 update that had been available the whole time 2022-09-07:

arduino/serial-monitor#24

(we did not have any outstanding Dependabot PRs so it was not a matter of hitting the updates[*].open-pull-requests-limit value for that package-ecosystem)

I guess better late than never (which likely would be the case if we managed the versions manually). Even if it is a bit glitched, the pull requests I do receive from Dependabot are valuable so I think it is worth adding regardless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants