Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(codexnode): ensure timer loop is asyncSpawned #1038

Merged
merged 2 commits into from
Dec 16, 2024
Merged

fix(codexnode): ensure timer loop is asyncSpawned #1038

merged 2 commits into from
Dec 16, 2024
+7 −6

Conversation

emizzle
Copy link
Contributor

@emizzle emizzle commented Dec 13, 2024

  • prevents futures from silently failing
  • also stops clock after the validator is stopped, which will help with graceful shutdowns

@emizzle emizzle force-pushed the fix/fix-async-futures/2-codexnode branch from fd5d158 to 7aeac3c Compare December 13, 2024 03:45
@emizzle emizzle added this pull request to the merge queue Dec 16, 2024
Merged via the queue into master with commit 5f2ba14 Dec 16, 2024
17 checks passed
@emizzle emizzle deleted the fix/fix-async-futures/2-codexnode branch December 16, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benbierens benbierens benbierens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emizzle @benbierens