fix(validation): asyncSpawns run #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
emizzle
commented
Dec 13, 2024
emizzle
commented
- annotates run with raises: []
- asyncSpawns run, to ensure there are no escaping exceptions
emizzle
force-pushed
the
fix/fix-async-futures/2-validation
branch
from
6f8e0d1 to
bf0c26a
Compare
gmega
reviewed
Dec 13, 2024
|
|
||
| proc stop*(validation: Validation) {.async.} = | ||
| await validation.running.cancelAndWait() | ||
| if not validation.running.isNil and not validation.running.finished: |
There was a problem hiding this comment.
Ugh, when does this happen (the nil case)? If you call stop before start?
There was a problem hiding this comment.
It's a good question. Th nil check prevents SIGSEGV and the finished check prevents Defects like "future was completed more than once". Both are a PITA to debug and these checks prevent that pain. However, if validation.running is nil, then we could raise a Defect imo, because something didn't quite go right and we're in a bad state. BUT, we're stopping the module, so do we really care if validation.running is already nil? Probably not.
marcinczenko
approved these changes
Dec 13, 2024
- annotates run with raises: [] - asyncSpawns run, to ensure there are no escaping exceptions
emizzle
force-pushed
the
fix/fix-async-futures/2-validation
branch
from
bf0c26a to
c1d15da
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 16, 2024
- annotates run with raises: [] - asyncSpawns run, to ensure there are no escaping exceptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.