Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCC-14 #15

Merged
merged 11 commits into from
Aug 28, 2024
Merged

GCC-14 #15

merged 11 commits into from
Aug 28, 2024

Conversation

benbierens
Copy link
Contributor

@benbierens benbierens commented Aug 6, 2024

In GCC-14, pointer compatibility warnings have been promoted to errors.
This applies a compatible pointer type definition.

Copy link
Member

@markspanbroek markspanbroek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@arnetheduck
Copy link

what about compilers for which the flag does not exist (clang, older gcc etc)? ie has the option to actually fix the pointers been explored?

@benbierens
Copy link
Contributor Author

what about compilers for which the flag does not exist (clang, older gcc etc)? ie has the option to actually fix the pointers been explored?

I did look into that. I was unable to find out what the nim equivalent of the C type should be. It's a const void* const * const. Clearly it aligns with nim ptr pointer, but I have no idea how to make GCC see that. If you have the answer, I'd be happy to learn a thing or two!

@arnetheduck
Copy link

Most our libraries have had to go through this process such as status-im/nim-bearssl#62 - just look for gcc 14 in any bumped deps.

@benbierens
Copy link
Contributor Author

OK that was disgustingly simple. Thanks so much, Arne!

@benbierens benbierens changed the title Make it work for gcc-14 GCC-14 Aug 20, 2024
@benbierens benbierens merged commit 3e09d81 into main Aug 28, 2024
6 checks passed
@benbierens benbierens deleted the gcc-14 branch August 28, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants