[Feature] i18n

[neSpecc]

• ability to change all internal UI texts
• ability to change titles of the Inline and Block tools
• ability to pass translations to the tools that can be accessed by tools developers by API

Resolves #751

[gohabereg]

Type should be moved to type variable or interface.
Here it's {[key: string]: any}, however I18n.currentDictionary is {[key: string]: object}

Also, it's better to specify the type is recurrent:

type DictValue = {[key: string]: Dictionary | string} | string;
type Dictionary = {[key: string]: DictValue};

[gohabereg]

However, if the root level of the dictionary has known properties, it's better to specify them:

interface I18nDict {
  tools: Dictionary;
  blockTunes: Dictionary;
  ...
}

[gohabereg]

Maybe better to name it getNamespace as the arg name is 'namespace'?

[gohabereg]

Don't think a tool will need access to the whole i18n dict. Maybe just left tn here and rename it to t?

[gohabereg]

I mean, pass only t method with the namespace just for tool

[gohabereg]

I think we should move all internal namespaces and messages to typed objects or enums

[gohabereg]

Unnecessary literal

[gohabereg]

Enums should be in PascalCase

Suggested change

	export enum toolTypes {
	export enum ToolTypes {

[gohabereg]

Also, usually, enums go in singular form

Suggested change

	export enum toolTypes {
	export enum ToolType {

[gohabereg]

Enum values also usually go in PascalCase

Suggested change

	BLOCK,
	Block,

[gohabereg]

Need to check here if section[dictKey] is an object (or not a string)

[neSpecc]

Section is always an object

[gohabereg]

As calls are not typesafe, you can pass path to value, not section

[neSpecc]

so the section will be undefined, and this if covers this case

[gohabereg]

Don't think key is a good name here

[gohabereg]

I think all fields should be optional (if we should be able to translate some parts and don't translate other) or required (if a dictionary is required to be applied to all parts)

[gohabereg]

Other types also should be exported from index.d.ts to be accessible by import from @editorjs/editorjs package

[neSpecc]

done

[neSpecc]

[gohabereg]

Args types are not defined

[gohabereg]

Maybe put tools and blockTunes to constant?

[gohabereg]

Somewhere next by ToolType enum

[gohabereg]

ESLint should throw a warning that param type is not defined

[neSpecc]

param types do not required by jsdoc because they are defined in typescript

[gohabereg]

I think it's better to put this file into src/types-internal folder