Recent note list #239
Merged
Recent note list #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
e11sy
commented
Mar 30, 2024
•
e11sy
commented
- get rid of noteList service
- added insertNoteVisit method to database helpers
- now noteList router uses note service
- added migration to make user_id index in note_visits table not unique (for each user there would be many note visits)
- refactored noteList.test
- updated eslint-config-codex to latest version since it treats unused vars different
- added storage method to get noteList ordered by time of last visit - get rid of the NoteListService (moved to NoteService) - minor fixes in noteVisits model
- moved noteList tests to note tests - implemented insertNoteVisit method to database helpers
neSpecc
reviewed
Mar 30, 2024
- deleted unwanted repository usage - comments improved - added order by visitedAt field for note list
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
elizachi
reviewed
Mar 30, 2024
neSpecc
reviewed
Mar 30, 2024
migrations/tenant/0028-note-visits@make-user-id-index-not-unique.sql
Outdated
Show resolved
Hide resolved
TatianaFomina
approved these changes
Apr 2, 2024
neSpecc
reviewed
Apr 3, 2024
- removed unwanted eslint disable respectfully to latest eslint-config-codex - updated eslint-config-codex version in package.json
elizachi
approved these changes
Apr 3, 2024
neSpecc
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.