Skip to content
This repository has been archived by the owner on Oct 2, 2018. It is now read-only.

Line 368 using wrong string method. #167

Closed
jackd1 opened this issue Feb 25, 2014 · 2 comments
Closed

Line 368 using wrong string method. #167

jackd1 opened this issue Feb 25, 2014 · 2 comments

Comments

@jackd1
Copy link
Member

jackd1 commented Feb 25, 2014

Line 368 in firetext.js is clearly using the wrong string method (sub is for surrounding the text with a <sub> tag). I meant to file this a while ago. Does anyone know which method this should be? (there are several slightly different string methods that this might be)

@ferndot
Copy link
Member

ferndot commented Feb 25, 2014

Maybe string.substring()? That is a common error.

@jackd1
Copy link
Member Author

jackd1 commented Feb 25, 2014

Probably either substring or substr. They behave the same with one arg. though, I'll make a quick fix.

@jackd1 jackd1 closed this as completed in 610c0f7 Feb 25, 2014
jackd1 added a commit that referenced this issue Mar 6, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants