-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Container size reduction #203
Conversation
* feat: reduce container built size * test: trigger CI * chore(deps): bump node to v20.11.0 * Revert "test: trigger CI" This reverts commit 16f2360. * refactor: modify dockerfile * feat: add git
hey @rdash99, did you mean to close? I was testing as we speak. Was there an issue you found with the optimization? |
Nope sorry - I was trying to squash my commits down and mangled it |
I think it should be good to go now - apologies for any confusion |
@rdash99 I'm going to definitely test and accept this optimization if it works well! Just wanted to give you a heads up though, the following is the suggested way to use it: https://github.com/codfish/semantic-release-action?tab=readme-ov-file#which-version-to-use # Recommended: Docker image digest from GitHub Container Registry (best for speed & security)
- uses: docker://ghcr.io/codfish/semantic-release-action@sha256:9e0bbcc4ca3b3611668dcf911e51432573efb3222587c4ca1cc8a759c1b8283c when you do this, your workflow doesn't need to build the image, they just pull it so it should be little faster. Should theoretically be even faster after your change too |
We currently do use that style in our actual workflows but we currently point to a cached version of the container on our own infrastructure to try to speed up pulls as much as possible as pulling the container has been one of the slowest parts of our actions runs generally. |
I was testing this in our repo where we host our workflows today and felt it would be a potential contribution :) |
🎉 This PR is included in version 3.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
@rdash99 thanks again! just merged and updated, latest version has a digest of |
Related Issue
#202
Description
This changes the Dockerfile to reduce the built container size to 297MB - reducing the pull time significantly. This also leads to less layers and hopefully less compression which was one of the major slowdowns for extracting after download.